Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for permissions_mode to aws_qldb_ledger #20302

Merged
merged 3 commits into from
Jul 27, 2021
Merged

Add support for permissions_mode to aws_qldb_ledger #20302

merged 3 commits into from
Jul 27, 2021

Conversation

gruebel
Copy link
Contributor

@gruebel gruebel commented Jul 24, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #20301

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSQLDBLedger_'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSQLDBLedger_ -timeout 180m
=== RUN   TestAccAWSQLDBLedger_basic
=== PAUSE TestAccAWSQLDBLedger_basic
=== RUN   TestAccAWSQLDBLedger_update
=== PAUSE TestAccAWSQLDBLedger_update
=== RUN   TestAccAWSQLDBLedger_Tags
=== PAUSE TestAccAWSQLDBLedger_Tags
=== CONT  TestAccAWSQLDBLedger_basic
=== CONT  TestAccAWSQLDBLedger_Tags
=== CONT  TestAccAWSQLDBLedger_update
--- PASS: TestAccAWSQLDBLedger_basic (221.57s)
--- PASS: TestAccAWSQLDBLedger_update (248.31s)
--- PASS: TestAccAWSQLDBLedger_Tags (271.13s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       272.847s
...

@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/qldb Issues and PRs that pertain to the qldb service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. size/M Managed by automation to categorize the size of a PR. labels Jul 24, 2021
github-actions[bot]
github-actions bot reviewed Jul 24, 2021
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @gruebel 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@anGie44 anGie44 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Jul 26, 2021
ewbankkit
ewbankkit approved these changes Jul 27, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TESTARGS='-run=TestAccAWSQLDBLedger_\|TestAccDataSourceAwsQLDBLedger_'  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSQLDBLedger_\|TestAccDataSourceAwsQLDBLedger_ -timeout 180m
=== RUN   TestAccDataSourceAwsQLDBLedger_basic
=== PAUSE TestAccDataSourceAwsQLDBLedger_basic
=== RUN   TestAccAWSQLDBLedger_basic
=== PAUSE TestAccAWSQLDBLedger_basic
=== RUN   TestAccAWSQLDBLedger_update
=== PAUSE TestAccAWSQLDBLedger_update
=== RUN   TestAccAWSQLDBLedger_Tags
=== PAUSE TestAccAWSQLDBLedger_Tags
=== CONT  TestAccDataSourceAwsQLDBLedger_basic
=== CONT  TestAccAWSQLDBLedger_Tags
=== CONT  TestAccAWSQLDBLedger_basic
=== CONT  TestAccAWSQLDBLedger_update
=== CONT  TestAccDataSourceAwsQLDBLedger_basic
--- PASS: TestAccDataSourceAwsQLDBLedger_basic (334.33s)
--- PASS: TestAccAWSQLDBLedger_basic (237.89s)
--- PASS: TestAccAWSQLDBLedger_update (250.10s)
--- PASS: TestAccAWSQLDBLedger_Tags (280.11s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	337.661s
GovCloud
% make testacc TESTARGS='-run=TestAccAWSQLDBLedger_\|TestAccDataSourceAwsQLDBLedger_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSQLDBLedger_\|TestAccDataSourceAwsQLDBLedger_ -timeout 180m
=== RUN   TestAccDataSourceAwsQLDBLedger_basic
=== PAUSE TestAccDataSourceAwsQLDBLedger_basic
=== RUN   TestAccAWSQLDBLedger_basic
=== PAUSE TestAccAWSQLDBLedger_basic
=== RUN   TestAccAWSQLDBLedger_update
=== PAUSE TestAccAWSQLDBLedger_update
=== RUN   TestAccAWSQLDBLedger_Tags
=== PAUSE TestAccAWSQLDBLedger_Tags
=== CONT  TestAccDataSourceAwsQLDBLedger_basic
=== CONT  TestAccAWSQLDBLedger_Tags
=== CONT  TestAccAWSQLDBLedger_basic
=== CONT  TestAccAWSQLDBLedger_update
=== CONT  TestAccAWSQLDBLedger_Tags
    provider_test.go:735: skipping tests; partition aws-us-gov does not support qldb service
=== CONT  TestAccAWSQLDBLedger_basic
    provider_test.go:735: skipping tests; partition aws-us-gov does not support qldb service
--- SKIP: TestAccAWSQLDBLedger_basic (1.48s)
=== CONT  TestAccDataSourceAwsQLDBLedger_basic
    provider_test.go:735: skipping tests; partition aws-us-gov does not support qldb service
--- SKIP: TestAccAWSQLDBLedger_Tags (1.48s)
--- SKIP: TestAccDataSourceAwsQLDBLedger_basic (1.48s)
=== CONT  TestAccAWSQLDBLedger_update
    provider_test.go:735: skipping tests; partition aws-us-gov does not support qldb service
--- SKIP: TestAccAWSQLDBLedger_update (1.48s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.593s

@ewbankkit
Copy link
Contributor

@gruebel Thanks for the contribution 🎉 👏.
I made one change to the DS (permissions_mode is Computed, not Required).

@ewbankkit ewbankkit merged commit d7b34f7 into hashicorp:main Jul 27, 2021
@github-actions github-actions bot added this to the v3.52.0 milestone Jul 27, 2021
@gruebel
Copy link
Contributor Author

gruebel commented Jul 27, 2021

@ewbankkit makes sense, thanks!

@github-actions
Copy link

This functionality has been released in v3.52.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/qldb Issues and PRs that pertain to the qldb service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.52.0
Development

Successfully merging this pull request may close these issues.

Add Permissions Mode support to QLDB Ledger
3 participants
@gruebel @ewbankkit @anGie44